[5.3] Github Actions: Automatic codestyle fixes for PRs #45652
Conversation
* Add phpstan to github action * Update ci.yml * Update ci.yml
|
Can we somehow test this before it gets merged? |
|
It has to be first in a branch of the target repo and then we would have to create a PR which has some broken codestyle. So, to be honest, I would rather merge this first and in worst case revert it later. |
|
for such things we can use another branch and play there |
|
So basically a pr against Hackwar:ghactions-codestyle would be enough for testing. Or? |
|
You might be right. 😄 |
| ./libraries/vendor/bin/${{ matrix.command }} | ||
| - uses: parkerbxyz/suggest-changes@v2 | ||
| with: | ||
| comment: 'Your code does not comply with our codestyle. Please commit the suggested changes.' |
There was a problem hiding this comment.
not a fan of the word "comply" how about
"Your code does not follow our codestyle. Please commit the suggested changes."
or
"Your code does not meet our codestyle requirements. Please commit the suggested changes."
There was a problem hiding this comment.
I'm currently unable to do this myself. If you suggest this as a change, I can accept it here in the interface and we can move forward with this.
Summary of Changes
This PR implements automatic codestyle fixes to pull requests. When a PR does not have the right codestyle, this will create suggestions to fix it.