Skip to content

[6.0] Remove the dispatch event functions in model and view #45431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented May 5, 2025

Summary of Changes

Removes the dispatchEvent functions in the view and model class. Therefor the getDispatcher overrides are not required anymore.

Testing Instructions

Install test sample data and browse around the front end and back end.

Actual result BEFORE applying this Pull Request

All is working.

Expected result AFTER applying this Pull Request

All is working.

Link to documentations

Please select:

@HLeithner
Copy link
Member

I have tested this item ✅ successfully on f58928c

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45431.

@laoneo laoneo closed this May 26, 2025
@laoneo laoneo deleted the remove/dispatcher branch May 26, 2025 07:24
@rdeutz rdeutz restored the remove/dispatcher branch May 28, 2025 16:12
@rdeutz rdeutz reopened this May 28, 2025
@ceford
Copy link
Contributor

ceford commented May 30, 2025

I have tested this item ✅ successfully on f58928c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45431.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45431.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 2, 2025
@Bodge-IT Bodge-IT merged commit 2bd3afa into joomla:6.0-dev Jun 18, 2025
3 of 4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 18, 2025
@Bodge-IT
Copy link
Contributor

Thanks for work @laoneo and thanks for taking time to test @ceford and @HLeithner

@Bodge-IT Bodge-IT added this to the Joomla! 6.0.0 milestone Jun 18, 2025
@laoneo laoneo deleted the remove/dispatcher branch June 18, 2025 17:10
Fedik added a commit to Fedik/joomla-cms that referenced this pull request Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b/c break This item changes the behavior in an incompatible why. HEADS UP PR-6.0-dev Unit/System Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants