-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Remove the dispatch event functions in model and view #45431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on f58928c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45431. |
rdeutz
approved these changes
May 28, 2025
HLeithner
approved these changes
May 28, 2025
I have tested this item ✅ successfully on f58928c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45431. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45431. |
Thanks for work @laoneo and thanks for taking time to test @ceford and @HLeithner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
b/c break
This item changes the behavior in an incompatible why. HEADS UP
PR-6.0-dev
Unit/System Tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Removes the
dispatchEvent
functions in the view and model class. Therefor thegetDispatcher
overrides are not required anymore.Testing Instructions
Install test sample data and browse around the front end and back end.
Actual result BEFORE applying this Pull Request
All is working.
Expected result AFTER applying this Pull Request
All is working.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Remove the dispatch event functions in model and view Manual#458
No documentation changes for manual.joomla.org needed