[6.0] Drop Bootstrap::framework #44991

dgrammatiko · 2025-02-24T07:22:27Z

Pull Request for Issue # .

Summary of Changes

B/C break
Drop Bootstrap::framework Since J4 any bootstrap (js) component should be specifically loaded, the framework fn was kept for compatibility

Testing Instructions

code review
Add HTMLHelper::_('bootstrap.framework'); somewhere in the index.php of the atum template
Check that all the BS components are registered

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: PR
No documentation changes for manual.joomla.org needed

HLeithner

can you please do only on chance in one pr.

you update package-lock.json (version numer)
you change code style
you use deprecated Factory::getDocument()

and the only thing this PR should do is to remove lines 588 to 616 in the Bootstrap.php

laoneo · 2025-02-24T08:38:10Z

Istead fo removing, I would move it to the compat plugin.

Hackwar · 2025-02-24T09:48:31Z

Do we have to add the deprecated tag to the methods in the compat plugin as well?

dgrammatiko · 2025-02-24T09:58:50Z

Do we have to add the deprecated tag to the methods in the compat plugin as well?

To me it feels redundant, as it will never show up in the IDE

Hackwar · 2025-02-24T10:26:34Z

I agree that it wont show up in the IDE, but it will prevent any discussions in the future about removal and deprecation if you move the tag from the old code also over to the new code.

Hackwar · 2025-02-24T10:30:53Z

Thank you!

softforge · 2025-02-24T16:30:24Z

@dgrammatiko I like this change and the addition to the compatibility plugin, to then remove it after.
Can you do as @HLeithner suggested and we can get testing done and merge it

HLeithner · 2025-02-24T16:42:00Z

the implementation in the b/c plugin is not optimal.

please add a new Class for this function and also an option to disable "all html helper functions" (do we have more?) and make it as option please.

dgrammatiko · 2025-02-24T17:01:50Z

please add a new Class

what namespace? is namespace Joomla\Plugin\Behaviour\Compat\HTML\Bootstrap ok?

and also an option

simple toggle should be ok here?

@softforge the first batch of requests is already done, I'll do the lest 2 later on (or tomorrow)

HLeithner · 2025-02-24T17:11:11Z

yes namespace is ok, we already have yes/no fields in the config. something like that

dgrammatiko · 2025-02-24T17:25:43Z

toggler added
moved to own class

administrator/language/en-GB/plg_behaviour_compat.ini

plugins/behaviour/compat/src/Extension/Compat.php

plugins/behaviour/compat/src/HTMLHelper/Bootstrap.php

Fedik · 2025-02-27T11:59:55Z

I have tested this item ✅ successfully on 30d3736

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44991.}

brianteeman · 2025-02-27T13:01:13Z

administrator/language/en-GB/plg_behaviour_compat.ini

@@ -8,6 +8,8 @@ PLG_COMPAT_FIELD_CLASSES_ALIASES_LABEL="Classes Aliases"
 PLG_COMPAT_FIELD_CLASSES_ALIASES_DESCRIPTION="Add class aliases for classes which have been renamed or moved to a namespace."
 PLG_COMPAT_FIELD_ES5_ASSETS_DESCRIPTION="Activate this option if your extension requires *.es5 assets which has resulted in an exception. The assets provided are empty but prevent the exception."
 PLG_COMPAT_FIELD_ES5_ASSETS_LABEL="ES5 Assets"
+PLG_COMPAT_FIELD_HTML_HELPERS_DESCRIPTION="Activate this option if your extension requires deprecated HTMLHelper classes or functions. When enabled, will provide backward compatibility to the prior major version."


why not state the version number

I've tried the not original take here and I copied that part from here:

PLG_COMPAT_XML_DESCRIPTION="If you use extensions which are not using the current Joomla Coding standards then this plugin, when enabled, will provide backward compatibility to the prior major version."

brianteeman · 2025-02-27T13:03:55Z

administrator/language/en-GB/plg_behaviour_compat.ini

@@ -8,6 +8,8 @@ PLG_COMPAT_FIELD_CLASSES_ALIASES_LABEL="Classes Aliases"
 PLG_COMPAT_FIELD_CLASSES_ALIASES_DESCRIPTION="Add class aliases for classes which have been renamed or moved to a namespace."
 PLG_COMPAT_FIELD_ES5_ASSETS_DESCRIPTION="Activate this option if your extension requires *.es5 assets which has resulted in an exception. The assets provided are empty but prevent the exception."
 PLG_COMPAT_FIELD_ES5_ASSETS_LABEL="ES5 Assets"
+PLG_COMPAT_FIELD_HTML_HELPERS_DESCRIPTION="Activate this option if your extension requires deprecated HTMLHelper classes or functions. When enabled, will provide backward compatibility to the prior major version."
+PLG_COMPAT_FIELD_HTML_HELPERS_LABEL="HTML Helpers"


to avoid confusion should this not be specific and refer to boostrap html helpers

Hmm, Harald suggested one switch for all (probably there are more, haven't really checked) of them: #44991 (comment)

FWIW one or multiple switches is fine by me

richard67 · 2025-03-04T10:37:38Z

I've allowed myself to fix the conflicts in files "plugins/behaviour/compat/compat.xml" and "administrator/language/en-GB/plg_behaviour_compat.ini" which were caused by the recent merged of PR #44240 .

dgrammatiko · 2025-07-17T19:23:10Z

@softforge any interest here?

dgrammatiko · 2025-07-17T19:54:05Z

@softforge ping

softforge · 2025-07-18T07:22:41Z

Im getting ready for alpha3 but will take a look over the weekend. Im still seeing one issue form @HLeithner , @HLeithner is it all good from your point of view?

dgrammatiko · 2025-07-18T07:59:02Z

This should be ok now

HLeithner · 2025-07-18T11:00:51Z

I would prefer to move the event to onAfterInitialise, it's a bit earlier. after this it should be ready to merge

dgrammatiko · 2025-07-26T07:08:33Z

The class is now using the onAfterInitialise event as requested

heelc29 · 2025-07-28T16:28:29Z

Look like still used

joomla-cms/administrator/components/com_config/tmpl/component/default.php

Line 35 in 108662f

HTMLHelper::_('bootstrap.framework');

joomla-cms/libraries/src/HTML/Helpers/Dropdown.php

Line 55 in 108662f

HTMLHelper::_('bootstrap.framework');

Test in backend that the styles list -- can open options (failed)

Test in backend that the templates list -- can open options (failed)

dgrammatiko · 2025-07-28T17:10:23Z

The dropdown helper should be removed as I think it doesn’t even work (ie it uses jquery code without loading the jquery lib) 😃

the config just needs to load manually some things

I’ll update the pr

- use the dropdown module in the dropdown HTMLHelper - Remove the call to `bootstrap.framework` in com_config as it was add in 4.0 alpha1 way before we switched to our own tabs script

dgrammatiko · 2025-08-15T18:48:15Z

@heelc29 so I fixed both the 2 existing instances, in the case of dropdown we just load the dropdown module in the case of com_config the addition of bootstrap.framework was done with aa661a1 but it's not needed anymore as for the tabs we are not using bootstrap anymore!

plugins/behaviour/compat6/src/Extension/Compat6.php

Co-authored-by: Quy Ton <quy@nomonkeybiz.com>

Requested changes have been made.

joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev labels Feb 24, 2025

dgrammatiko force-pushed the 6.0-dev/remove-bs-fw branch from c5bafe0 to 9fbe4e3 Compare February 24, 2025 07:24

HLeithner previously requested changes Feb 24, 2025

View reviewed changes

HLeithner added the b/c break This item changes the behavior in an incompatible why. HEADS UP label Feb 24, 2025

dgrammatiko force-pushed the 6.0-dev/remove-bs-fw branch from 9fbe4e3 to a83af47 Compare February 24, 2025 08:10

joomla-cms-bot removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Feb 24, 2025

joomla-cms-bot added the Language Change This is for Translators label Feb 24, 2025

dgrammatiko requested a review from HLeithner February 24, 2025 17:39

ghost reviewed Feb 24, 2025

View reviewed changes

administrator/language/en-GB/plg_behaviour_compat.ini Outdated Show resolved Hide resolved

Fedik reviewed Feb 25, 2025

View reviewed changes

plugins/behaviour/compat/src/Extension/Compat.php Outdated Show resolved Hide resolved

Fedik added the Removal Removes functionality label Feb 27, 2025

Fedik reviewed Feb 27, 2025

View reviewed changes

plugins/behaviour/compat/src/HTMLHelper/Bootstrap.php Outdated Show resolved Hide resolved

brianteeman reviewed Feb 27, 2025

View reviewed changes

laoneo removed the Removal Removes functionality label Feb 28, 2025

HLeithner mentioned this pull request Apr 29, 2025

Remove HTMLHelper::Bootstrap('framework') joomla/Manual#396

Open

dgrammatiko force-pushed the 6.0-dev/remove-bs-fw branch from 0d3a1c2 to cd3ca4e Compare July 17, 2025 19:52

dgrammatiko added 14 commits August 15, 2025 21:35

Drop Bootstrap::framework

c27037e

move the code to the compat plg

20644fc

add back the deprecation

c8b03a9

use own class, use toggler

2a5dd66

cs

7d26b0b

meh

0cdfd09

refactor

c05374c

cs

81aa661

Update Bootstrap.php

4a42ebc

fix conflicts

935311b

meh

b2d6991

Update Compat6.php

b740bec

Update Compat6.php

a280a32

fixes

9c4941c

- use the dropdown module in the dropdown HTMLHelper - Remove the call to `bootstrap.framework` in com_config as it was add in 4.0 alpha1 way before we switched to our own tabs script

dgrammatiko force-pushed the 6.0-dev/remove-bs-fw branch from d7a4256 to 9c4941c Compare August 15, 2025 18:45

QuyTon reviewed Aug 15, 2025

View reviewed changes

plugins/behaviour/compat6/src/Extension/Compat6.php Outdated Show resolved Hide resolved

Update plugins/behaviour/compat6/src/Extension/Compat6.php

05a430f

Co-authored-by: Quy Ton <quy@nomonkeybiz.com>

Merge branch '6.0-dev' into 6.0-dev/remove-bs-fw

9443e1e

bembelimen added the bug label Aug 20, 2025

Uh oh!

[6.0] Drop Bootstrap::framework #44991

Are you sure you want to change the base?

[6.0] Drop Bootstrap::framework #44991

Conversation

dgrammatiko commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Uh oh!

HLeithner left a comment

Choose a reason for hiding this comment

Uh oh!

laoneo commented Feb 24, 2025

Uh oh!

Hackwar commented Feb 24, 2025

Uh oh!

dgrammatiko commented Feb 24, 2025

Uh oh!

Hackwar commented Feb 24, 2025

Uh oh!

Hackwar commented Feb 24, 2025

Uh oh!

softforge commented Feb 24, 2025

Uh oh!

HLeithner commented Feb 24, 2025

Uh oh!

dgrammatiko commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HLeithner commented Feb 24, 2025

Uh oh!

dgrammatiko commented Feb 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fedik commented Feb 27, 2025

Uh oh!

brianteeman Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

dgrammatiko Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

brianteeman Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

dgrammatiko Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

dgrammatiko Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

richard67 commented Mar 4, 2025

Uh oh!

dgrammatiko commented Jul 17, 2025

Uh oh!

dgrammatiko commented Jul 17, 2025

Uh oh!

softforge commented Jul 18, 2025

Uh oh!

dgrammatiko commented Jul 18, 2025

Uh oh!

HLeithner commented Jul 18, 2025

Uh oh!

dgrammatiko commented Jul 26, 2025

Uh oh!

heelc29 commented Jul 28, 2025

Uh oh!

dgrammatiko commented Jul 28, 2025

Uh oh!

dgrammatiko commented Aug 15, 2025

Uh oh!

Uh oh!

Uh oh!

dgrammatiko commented Feb 24, 2025 •

edited

Loading

dgrammatiko commented Feb 24, 2025 •

edited

Loading