Skip to content

[6.0] Remove LegacyPropertyManagementTrait from MVC classes #44907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: 6.0-dev
Choose a base branch
from

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Feb 14, 2025

Summary of Changes

The LegacyPropertyManagementTrait has been deprecated for quite some time and will most likely be removed in 7.0. This removes its usage from the base model and view classes of the CMS. This might look like quite a big break in b/c, but if you followed Joomla core code since Joomla 2.5, it isn't actually that big. We've not been using it anywhere really, except for the ->get() method in the views, which calls the methods from the models. However this has always been an overwritten method in the view anyway and it also still exists after this change. This means that all those old view classes will still work like before. The code from the trait has been deprecated since Joomla 3.4.0, even though it has been moved around and with Joomla 4.0 has finally ended up in the legacy trait. From my perspective, it is time to do this after 11 years of it being deprecated: https://github.com/joomla/joomla-cms/blob/3.4.0/libraries/joomla/object/object.php

Testing Instructions

Codereview.

Link to documentations

Please select:

@Hackwar Hackwar added the b/c break This item changes the behavior in an incompatible why. HEADS UP label Feb 14, 2025
@heelc29
Copy link
Contributor

heelc29 commented Jun 11, 2025

tests failing because its still used here

$view->set('component_name', $this->input->get('component_name'));

@Hackwar
Copy link
Member Author

Hackwar commented Jun 11, 2025

Thanks, I removed that now.

@Hackwar Hackwar marked this pull request as ready for review June 11, 2025 11:56
@Hackwar
Copy link
Member Author

Hackwar commented Jun 23, 2025

Now that the documentation is also done, this one is ready for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b/c break This item changes the behavior in an incompatible why. HEADS UP PR-6.0-dev Unit/System Tests
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants