Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] [CLI] enable or disable extension command #43977

Open
wants to merge 13 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Aug 25, 2024

Pull Request for Issue #43949 .

Summary of Changes

new command to enable or disable an extension

Testing Instructions

run php cli\joomla.php extension:enable 226

run php cli\joomla.php extension:disable 226 to disable

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

enable or disable an extension from cli

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review August 25, 2024 07:39
@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:50
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5][CLI] enable or disable extension command [5.3] [CLI] enable or disable extension command Sep 2, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
@voronkovich
Copy link

I think it would be better to have two separate commands for enabling and disabling extensions: extension:enable and extension:disable. In my opinion, it is a bit confusing that the command "publish" also disables extensions.

Joomla has separate commands for installing and uninstalling extensions, as well as for getting and setting configuration values an so on. There is no commands such:

php cli/joomla extension:install --uninstall 123

php cli/joomla user:add --delete bob

php cli/joomla site:up --down

php cli/joomla database:export --import

@alikon
Copy link
Contributor Author

alikon commented Oct 18, 2024

2 separate command now

@brianteeman
Copy link
Contributor

Shouldnt all usage of publish/unpublish (including the file names) be changed to enable/disable?

alikon and others added 2 commits October 18, 2024 11:21
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
@voronkovich
Copy link

I think we should use enable/disable instead of publish/unpublish. Even a field in database has name enabled:

$table->enabled = 1;

alikon and others added 2 commits November 4, 2024 08:19
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
@Quy
Copy link
Contributor

Quy commented Nov 7, 2024

I have tested this item ✅ successfully on 43ef558


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43977.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants