Skip to content

[3.x] PR 300 follow up - Use ROW_NUMBER() windows function whenever supported #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hackwar merged 1 commit into from
Mar 30, 2025
Merged

[3.x] PR 300 follow up - Use ROW_NUMBER() windows function whenever supported #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Query/MysqlQueryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,8 @@ public function findInSet($value, $set)
*/
public function selectRowNumber($orderBy, $orderColumnAlias)
{
// Use parent method with ROW_NUMBER() window function on MariaDB 11.0.0 and newer.
if ($this->db->isMariaDb() && version_compare($this->db->getVersion(), '11.0.0', '>=')) {
// Use parent method with ROW_NUMBER() window function on MariaDB >= 10.2.0 and MySQL >= 8.0.0.
if (version_compare($this->db->getVersion(), $this->mariadb ? '10.2.0' : '8.0.0', '>=')) {
return parent::selectRowNumber($orderBy, $orderColumnAlias);
}

Expand Down