[3.x] Use directory Tests/Sqlsrv in phpunit.appveyor_sql2017.xml.dist to fix failing AppVeyor #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #
Summary of Changes
This pull request (PR) fixes the currently failing unit tests in AppVeyor in the 3.x-dev branch by changing the folder to be used for the tests from "Tests" to "Tests/Sqlsrv" in the "phpunit.appveyor_sql2017.xml.dist" file.
This is consistent with the other "phpunit.*.xml.dist" files, where the driver-specific folder is used:
Tests from base classes like e.g. AbstractDatabaseDriverTestCase or DatabaseTestCase are inhertited. If you would change that back to folder "Test" for these other configurations, the corresponding tests would also fail, so the change from this PR here seems to be the right change.
Testing Instructions
Check the AppVeyor log of this PR and compare with the log of some other open PR for the 3.x-dev branch.
Result:
Compare the bottom of the log of e.g. the PHP 8.1 test in AppVeyor with the log for the same test in Drone , e.g. "PHP 8.1 with MS SQL Server 2017-latest (sqlsrv)".
Result:
The AppVeyor tests for this PR show the same result as the corresponding tests in Drone for the same MS SQL Server and PHP versions.
Documentation Changes Required
None.