php 8.2 - dynamic property deperecation #273
Conversation
|
@nibra can you check this one |
|
the variable has to be public since it's now public to, it can be deprecated and changed to protected in the next major version. beside that this variable is never used (at least I didn't found a usage). show it could be removed completely in next release? |
|
Thank you! |
|
and whats your plan for this useless variable? |
|
This fix is included in the 3.0.0 release, but not in the 2.1.1 because that was made in 2022, long before this PR here (and possibly others) were merged into 2.0-dev. So in Joomla 4 we get the deprecated warning when using the PDO MySQL driver on PHP 8.2, and this then results in errors when error reporting is set to maximum. So it will need a new release 2.1.2 from the 2.0-dev branch first if we want to fix the problem with Joomla 4.4.1. @Hackwar do you think you can do that? It's not urgent, can be done after the 4.4.0 stable. For removing the unused variable as suggested by @HLeithner above it's too late now, also for the 3.x-dev branch as we already have a 3.0.0 release (where this PR is included). |
|
i'm still bitten by this
we have 4.4.3 now |
|
@richard67 |
|
Will this change make it into a Joomla 4.x release? Without it, sites completely break on PHP 8.2+ when error reporting is "maximum".
The deprecation warning preempts Joomla core setting HTTP headers, which makes all requests simply crash with "headers already sent by MysqlDriver.php" |
No Joomla 4 is in security only mode. |
5 participants
Deprecated: Creation of dynamic property Joomla\Database\Mysql\MysqlDriver::$charset is deprecated in /shared/httpd/dev4/joomla-cms/libraries/vendor/joomla/database/src/Mysql/MysqlDriver.php on line 128
Pull Request for Issue #
Summary of Changes
Testing Instructions
Documentation Changes Required