Skip to content

Conversation

@dkostyrev
Copy link
Collaborator

Description

Redis Scheduler Store serialised OperationId as a JSON, but deserialised it as String, which resulted in (Error 34 Not Found) when running Bazel build with RBE.

Fixes TraceMachina#1855

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I've observed the issue when running nativelink 0.6.0 (and snapshot versions) deployed in Kubernetes cluster by subscribing to the key misses on Redis instance used as a scheduler store.

redis-cli -c -u redis://localhost:6379 config set notify-keyspace-events KEm
redis-cli --csv psubscribe '__key*__:aa*'
"psubscribe","__key*__:aa*",1
"pmessage","__key*__:aa*","__keyspace@0__:aa_{\"Uuid\":\"9ad3639a-879f-4cc0-89c7-69186c13e6a0\"}","keymiss"
"pmessage","__key*__:aa*","__keyspace@0__:aa_{\"Uuid\":\"738f1da4-f311-4273-a3f7-60c294249df9\"}","keymiss"
"pmessage","__key*__:aa*","__keyspace@0__:aa_{\"Uuid\":\"147a9c57-c0a2-46c9-ab7d-bd0a96d45c65\"}","keymiss"

And I've reproduced the issue by adding get_awaited_action_by_id call in add_action_smoke_test.

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@dkostyrev dkostyrev merged commit c2ee35f into release/0.6.1 Jul 4, 2025
1 check passed
@dkostyrev dkostyrev deleted the fix/inconsistent-read-write-format-redis-scheduler-0.6.0 branch July 4, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants