Fix inconsistency in read/write format of OperationId in Redis Scheduler Store #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redis Scheduler Store serialised OperationId as a JSON, but deserialised it as String, which resulted in (Error 34 Not Found) when running Bazel build with RBE.
Fixes TraceMachina#1855
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
I've observed the issue when running nativelink 0.6.0 (and snapshot versions) deployed in Kubernetes cluster by subscribing to the key misses on Redis instance used as a scheduler store.
And I've reproduced the issue by adding
get_awaited_action_by_idcall inadd_action_smoke_test.Checklist
bazel test //...passes locallygit amendsee some docsThis change is