Skip to content

Commit

Permalink
hwmon: (lan966x) Use the devm_clk_get_enabled() helper function
Browse files Browse the repository at this point in the history
Use the devm_clk_get_enabled() helper function instead of hand-writing it.
It saves some line of codes.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/25f2ab4c61d4fc48e8200f8754bb446f2b89ea89.1688795527.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
tititiou36 authored and groeck committed Aug 21, 2023
1 parent c15a8ed commit 6698cbd
Showing 1 changed file with 1 addition and 23 deletions.
24 changes: 1 addition & 23 deletions drivers/hwmon/lan966x-hwmon.c
Original file line number Diff line number Diff line change
Expand Up @@ -334,24 +334,6 @@ static struct regmap *lan966x_init_regmap(struct platform_device *pdev,
return devm_regmap_init_mmio(&pdev->dev, base, &regmap_config);
}

static void lan966x_clk_disable(void *data)
{
struct lan966x_hwmon *hwmon = data;

clk_disable_unprepare(hwmon->clk);
}

static int lan966x_clk_enable(struct device *dev, struct lan966x_hwmon *hwmon)
{
int ret;

ret = clk_prepare_enable(hwmon->clk);
if (ret)
return ret;

return devm_add_action_or_reset(dev, lan966x_clk_disable, hwmon);
}

static int lan966x_hwmon_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
Expand All @@ -363,15 +345,11 @@ static int lan966x_hwmon_probe(struct platform_device *pdev)
if (!hwmon)
return -ENOMEM;

hwmon->clk = devm_clk_get(dev, NULL);
hwmon->clk = devm_clk_get_enabled(dev, NULL);
if (IS_ERR(hwmon->clk))
return dev_err_probe(dev, PTR_ERR(hwmon->clk),
"failed to get clock\n");

ret = lan966x_clk_enable(dev, hwmon);
if (ret)
return dev_err_probe(dev, ret, "failed to enable clock\n");

hwmon->clk_rate = clk_get_rate(hwmon->clk);

hwmon->regmap_pvt = lan966x_init_regmap(pdev, "pvt");
Expand Down

0 comments on commit 6698cbd

Please sign in to comment.