add Caffeine cache support #463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is derived from the Guava module. The changes were,
Cache,LoadingCache,CaffeineSpec)Note that
AsyncLoadingCachedoes not extend the Cache interface due to some minor differences. It would ideally be aLoadingCache<K, CompletableFuture<V>>, but that would require allowing a null return value (as Caffeine does not throw an exception on a cache miss). To support this type,doWithAsyncwas added along withAsyncCallback. The privatecallbackinstance has weaker type safety, but is internal so this has no negative effect. That approach allowed for making the most minimal changes from the original Guava code.