Add a queue for hotreload to group changes to fix #2577 #2583
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| Exception error = module.start(); | ||
| if (error == null) { | ||
| watcher.watch(); | ||
| se = Executors.newScheduledThreadPool(1); | ||
| se.scheduleAtFixedRate(this::actualRestart, initialDelayBeforeFirstRestartMillis, |
There was a problem hiding this comment.
FutureReturnValueIgnored: Return value of methods returning Future must be checked. Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| /** | ||
| * Set wait time before restart. | ||
| * | ||
| * @param waitTimeBeforeRestart |
There was a problem hiding this comment.
EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
| * @param waitTimeBeforeRestart | |
| * |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| Exception error = module.start(); | ||
| if (error == null) { | ||
| watcher.watch(); | ||
| se = Executors.newScheduledThreadPool(1); | ||
| se.scheduleAtFixedRate(this::actualRestart, initialDelayBeforeFirstRestartMillis, |
There was a problem hiding this comment.
FutureReturnValueIgnored: Return value of methods returning Future must be checked. Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| /** | ||
| * Set wait time before restart. | ||
| * | ||
| * @param waitTimeBeforeRestart |
There was a problem hiding this comment.
EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
| * @param waitTimeBeforeRestart | |
| * |
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
This is a fix for #2577
I tested it on Eclipse and the defaults seem good for our projects.