[HUDI-7148] Add an additional fix to the potential thread insecurity …

…problem of heartbeat client (apache#10188) Co-authored-by: dongsj <dongsj@asiainfo.com>
jonvex · Nov 29, 2023 · d1dfa5b · d1dfa5b
1 parent 77cfb3a
commit d1dfa5b
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/...i-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java b/...i-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java
@@ -266,6 +266,11 @@ private void updateHeartbeat(String instantTime) throws HoodieHeartbeatException
       heartbeat.setLastHeartbeatTime(newHeartbeatTime);
       heartbeat.setNumHeartbeats(heartbeat.getNumHeartbeats() + 1);
     } catch (IOException io) {
+      Boolean isHeartbeatStopped = instantToHeartbeatMap.get(instantTime).isHeartbeatStopped;
+      if (isHeartbeatStopped) {
+        LOG.warn(String.format("update heart beat failed, because the instant time %s was stopped ? : %s", instantTime, isHeartbeatStopped));
+        return;
+      }
       throw new HoodieHeartbeatException("Unable to generate heartbeat for instant " + instantTime, io);
     }
   }