Don't use deprecated apt-get --force-yes
#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed in my heroku build log that there's a bunch of `apt-get` warnings like this: ``` W: --force-yes is deprecated, use one of the options starting with --allow instead. ``` It looks like this line is the one responsible: https://github.com/jontewks/puppeteer-heroku-buildpack/blob/22c5b5960775a5befb89e8b9a1014bc8c1187e3f/bin/compile#L56 According to the [`apt-get` man page](https://manpages.debian.org/stretch/apt/apt-get.8.en.html), we can use `--allow-downgrades --allow-remove-essential --allow-change-held-packages` instead. Fixes jontewks#29
|
Thanks @josephfrazier, I am gonna merge this to a testing branch so I can deploy a specific branch on heroku to test there and then merge that branch to master once all done. I'll let you know when its merged too so you can get the latest and confirm its working for you as well! |
|
Perfect, thanks again! |
jontewks
added a commit
that referenced
this pull request
Oct 15, 2018
I noticed in my heroku build log that there's a bunch of `apt-get` warnings like this: ``` W: --force-yes is deprecated, use one of the options starting with --allow instead. ``` It looks like this line is the one responsible: https://github.com/jontewks/puppeteer-heroku-buildpack/blob/22c5b5960775a5befb89e8b9a1014bc8c1187e3f/bin/compile#L56 According to the [`apt-get` man page](https://manpages.debian.org/stretch/apt/apt-get.8.en.html), we can use `--allow-downgrades --allow-remove-essential --allow-change-held-packages` instead. Fixes #29
jontewks
pushed a commit
that referenced
this pull request
Oct 15, 2018
I noticed in my heroku build log that there's a bunch of `apt-get` warnings like this: ``` W: --force-yes is deprecated, use one of the options starting with --allow instead. ``` It looks like this line is the one responsible: https://github.com/jontewks/puppeteer-heroku-buildpack/blob/22c5b5960775a5befb89e8b9a1014bc8c1187e3f/bin/compile#L56 According to the [`apt-get` man page](https://manpages.debian.org/stretch/apt/apt-get.8.en.html), we can use `--allow-downgrades --allow-remove-essential --allow-change-held-packages` instead. Fixes #29
|
Thanks so much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in my heroku build log that there's a bunch of
apt-getwarnings like this:It looks like this line is the one responsible:
puppeteer-heroku-buildpack/bin/compile
Line 56 in 22c5b59
According to the
apt-getman page,we can use
--allow-downgrades --allow-remove-essential --allow-change-held-packagesinstead.Fixes #29