Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input font size #19

Merged
merged 4 commits into from
Oct 4, 2020
Merged

Input font size #19

merged 4 commits into from
Oct 4, 2020

Conversation

brettinternet
Copy link
Contributor

Optional solution for #18

.editorconfig Outdated Show resolved Hide resolved
static/css/main.css Outdated Show resolved Hide resolved
@brettinternet brettinternet marked this pull request as ready for review October 1, 2020 20:38
@jonschoning
Copy link
Owner

jonschoning commented Oct 2, 2020

I added a commit to master which fixes the line endings in all the files that had them. if you could merge that into this pr that would be helpful. I'd like to try to get it so that the only changes in this PR to BMark.purs only affect the lines actually changed. The formatting changes in main.css are fine though.

i tested out the 16pt font size and i think this option in general looks pretty good.

@brettinternet
Copy link
Contributor Author

Great, I'll rebase with master then.

I'd like to try to get it so that the only changes in this PR to BMark.purs only affect the lines actually changed.

That makes sense, I'll revert the formatting changes that occurred.

Thank you for the feedback, I'll push an update this weekend.

@brettinternet
Copy link
Contributor Author

brettinternet commented Oct 3, 2020

After installing spago globally and other local deps within purs/ with npm i and make install, and making sure libtinfo.so is available, I'm still unable to run spago build within the Makefile in my environment. The stderr reads:

[error] Executable was not found in path: "purs"

This is odd because npx spago build does work.

Would you be able to push the build output to this PR?

@jonschoning jonschoning merged commit cdbb612 into jonschoning:master Oct 4, 2020
@brettinternet brettinternet deleted the input-font-size branch October 4, 2020 03:10
@jonschoning
Copy link
Owner

jonschoning commented Oct 4, 2020

hrm, thats unfortunate you couldn't get it to work. I'll see if i can replicate this on my end, but this is something probably to do with npm and environment specific, so i'm not sure if i'll be able to replicate this.

@brettinternet
Copy link
Contributor Author

I'll see if I can learn the stack more, I'm new to the tooling. Thank you for the help and merging these changes. 🙂

@jonschoning
Copy link
Owner

thanks for the PR!

@jonschoning
Copy link
Owner

@brettinternet fyi i pushed a commit 5dee5c6 which might fix your issues with the /purs build. I think in my environment i had the necessary tools installed globally, so the makefile was looking for those tools globally instead of locally.

if you get latest and try to to npm i and make install and make again, it might have a better chance of working for you now.

@brettinternet
Copy link
Contributor Author

Yes, that works for me now. I was stumped because the make cmd errored at line 9 (the spago build command), however I did have spago installed globally, and I do indeed have ~/.npm-global/bin in my path.

Unrelated to your library, but to clarify an additional step I had to take to get the Makefile to run, on my Linux distro I did have to symlink a dependency for libtinfo:

sudo ln -s /usr/lib/libtinfo.so.6 /usr/lib/libtinfo.so.5

I only mention this on the remote possibility that someone else runs into this issue.

I'm grateful for your help!

@jonschoning
Copy link
Owner

glad you got it working!

i've never run into the libtinfo issue on ubuntu before (currently 20.04.1 LTS), that sounds kind of annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants