Skip to content

Stop underscore highlighting in variable names #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

willbeaufoy
Copy link

Markdown uses underscores surrounding a piece of text to add emphasis, and this is reflected in this package by pink highlighing. However when underscores occur as part of a continuous bit of text (e.g. variable or function names), we don't want it to be highlighted. This fix ensures highlighting does not take place between underscores if the first underscore is preceeded by a word character.

Markdown uses underscores surrounding a piece of text to add emphasis, and this is reflected in this package by pink highlighing. However when underscores occur as part of a continuous bit of text (e.g. variable or function names), we don't want it to be highlighted. This fix ensures highlighting does not take place between underscores if the first underscore is preceeded by a word character.
@willbeaufoy
Copy link
Author

Hhm although this actually seems to remove all underscore highlighting behaviour even if not preceeded by a word. This isn't a problem for me but a better fix would preserve highlighting behaviour.

@jonschlinkert
Copy link
Owner

Thanks for the attempt! Sorry I was late to respond!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants