Skip to content

adds support for Jekyll '{% highlight %}' codeblocks #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gkemmey
Copy link
Contributor

@gkemmey gkemmey commented Nov 6, 2015

Jekyll has code blocks of the format:

{% highlight js %}
// cool javascript stuff
{% endhighlight %}

Jekyll uses Pygments for syntax highlighting out-of-the-box, so I don't know if all the words would match as is (i.e sql is mysql in pygments).

Anyway, I use Markdown Extended, but wanted it to also syntax highlight code when editing Jekyll blog files so this is what I've been using.

@jonschlinkert
Copy link
Owner

wow this is a great pr! nice work. Have you experienced any performance issue with the extra matching? it looks like there shouldn't be any problems.

@gkemmey
Copy link
Contributor Author

gkemmey commented Nov 7, 2015

I haven't, but I've just done some local testing on my various personal Markdown files. Any suggestions for trying something more exhaustive?

@jonschlinkert
Copy link
Owner

No, I wish I did lol. Would be nice if there was an easy way to run unit tests on packages. I'll pull this down asap and try to get it merged. Sorry for the delay but might be Mon. before I'll have a chance to review. thanks again!

@gkemmey
Copy link
Contributor Author

gkemmey commented Nov 7, 2015

No worries, my pleasure!

@jonschlinkert
Copy link
Owner

thanks again!

jonschlinkert added a commit that referenced this pull request Nov 10, 2015
adds support for Jekyll '{% highlight %}' codeblocks
@jonschlinkert jonschlinkert merged commit 63b9e72 into jonschlinkert:master Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants