Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor #28

Closed
wants to merge 2 commits into from
Closed

refactor #28

wants to merge 2 commits into from

Conversation

jonschlinkert
Copy link
Owner

Refactored to accomplish the following:

  • more performant - this release is very fast.
  • more resilient - this release addresses edge cases that currently aren't covered

@doowb please review when you get a chance. I'll add details about those points before we release. thanks!

and fixes package.json `files` property
@doowb
Copy link
Collaborator

doowb commented Apr 19, 2021

Question: Is parse being used for anything? I see it exported on setValue, but I don't see where it's being used.

Looks like this will require Node.js >=12 since .flatMap is not available in Node.js 10.
Other than that, looks good to me!

"description": "Create nested values and any intermediaries using dot notation (`'a.b.c'`) paths.",
"version": "3.0.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the version should be updated to the latest... I'm sure this will be bumped before publishing, but it might cause confusion when looking at the source on GitHub.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not the latest? I pulled down. Damn I wonder how I missed that.

@jonschlinkert
Copy link
Owner Author

Is parse being used for anything? I see it exported on setValue, but I don't see where it's being used.

It's not directly, but might be exposed on the API to use as a custom options.split function.

Looks like this will require Node.js >=12 since .flatMap is not available in Node.js 10.

Good catch. Instead, it makes more sense to not use .flatMap().

@jonschlinkert jonschlinkert deleted the dev branch April 28, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants