Support null and undefined values #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| return -1; | ||
| } else { | ||
| return a < b ? -1 : (a > b ? 1 : 0); | ||
| } | ||
| } |
There was a problem hiding this comment.
damn, I messed around with this and had similar logic to what you just did, but yours is cleaner. At least this validates that it will take something like this to fix the issue, I was wondering if there was an easier way.
There was a problem hiding this comment.
Yeah, I went through a bunch of different implementations and I think this uses the least amount of checks. And since > and < always return false when null is involved, this needs to be done.
|
I agree that this needs to be done here. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3.
I'm opening the PR to get feedback before publishing. Since the built-in
Array.prototype.sortfunction will pushnullandundefinedvalues to the end of the array, I implemented this in a similar fashion.My first thought was that this could be implemented with a custom compare function, but the
get-objectfunctionality would have to be added to that custom compare function too.