-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporter doesn't await for test.onStarted callback #252
Comments
It should be. I can't see any unawaited futures
https://github.com/jonsamwell/flutter_gherkin/blob/integration_test__package_support/lib/src/flutter/runners/gherkin_integration_test_runner.dart#L213
Are you able to do a sample that reproduces this error?
…On Wed, Jul 13, 2022, 8:20 PM Alexander ***@***.***> wrote:
The *test.onStarted* callback is not finished, but the *feature.onStarted*
is already called.
flutter_gherkin: 3.0.0-rc.16
—
Reply to this email directly, view it on GitHub
<#252>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4F7IJEUGRZESUDYRAALR3VT2J5BANCNFSM53OFXUFA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
What about this line
|
Good spot! I'll look at fixing this tomorrow.
…On Wed, Jul 13, 2022, 9:27 PM Alexander ***@***.***> wrote:
What about this line
https://github.com/jonsamwell/flutter_gherkin/blob/4378a2447d0e8d358cf746a22001871b754ccb83/lib/src/flutter/runners/gherkin_integration_test_runner.dart#L92
—
Reply to this email directly, view it on GitHub
<#252 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4F7IN5TFSIZXOFRHOSLE3VT2RZ5ANCNFSM53OFXUFA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
jonsamwell
added a commit
that referenced
this issue
Jul 25, 2022
- Fix #256 - Ensure all exceptions generated when running a step are logged - Fix #253 - Ensure features with descriptions that span more than one line are parsed correctly - Fix #252 - Ensure all async code is awaited - When taking a screenshot on the web use the render element rather than relying on native code that does not work
Fixed in 3.0.0-rc.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The test.onStarted callback is not finished, but the feature.onStarted is already called.
Also, as I understood none of them are awaited. So what is the point of making them async?
My goal is to report data to the server, and I need to receive IDs for each feature, scenario, and step and later use these ids to finish them on the server.
flutter_gherkin: 3.0.0-rc.16
The text was updated successfully, but these errors were encountered: