Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporter doesn't await for test.onStarted callback #252

Closed
SashaKryzh opened this issue Jul 13, 2022 · 4 comments
Closed

Reporter doesn't await for test.onStarted callback #252

SashaKryzh opened this issue Jul 13, 2022 · 4 comments

Comments

@SashaKryzh
Copy link

SashaKryzh commented Jul 13, 2022

The test.onStarted callback is not finished, but the feature.onStarted is already called.

Also, as I understood none of them are awaited. So what is the point of making them async?

My goal is to report data to the server, and I need to receive IDs for each feature, scenario, and step and later use these ids to finish them on the server.

flutter_gherkin: 3.0.0-rc.16

@jonsamwell
Copy link
Owner

jonsamwell commented Jul 13, 2022 via email

@SashaKryzh
Copy link
Author

What about this line

_safeInvokeFuture(() async => await reporter.test.onStarted.invoke());

@jonsamwell
Copy link
Owner

jonsamwell commented Jul 13, 2022 via email

jonsamwell added a commit that referenced this issue Jul 25, 2022
  - Fix #256 - Ensure all exceptions generated when running a step are logged
  - Fix #253 - Ensure features with descriptions that span more than one line are parsed correctly
  - Fix #252 - Ensure all async code is awaited
  - When taking a screenshot on the web use the render element rather than relying on native code that does not work
@jonsamwell
Copy link
Owner

Fixed in 3.0.0-rc.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants