Skip to content

Comments

Add error handler for 404 not found#105

Draft
jonodrew wants to merge 1 commit intomainfrom
error-handlers
Draft

Add error handler for 404 not found#105
jonodrew wants to merge 1 commit intomainfrom
error-handlers

Conversation

@jonodrew
Copy link
Owner

This will help in the case of users asking for data that's already been deleted

@jonodrew
Copy link
Owner Author

Better late than never, some error handling!

@johnpeart is there a pre-existing 404 error page we can re-use for this?

@github-actions
Copy link

github-actions bot commented Jun 25, 2022

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.9.13-final-0 -----------

Name Stmts Miss Cover
/app/init.py 22 0 100%
/app/auth/init.py 3 0 100%
/app/auth/routes.py 17 2 88%
/app/classes.py 83 3 96%
/app/config.py 10 1 90%
/app/errors/init.py 3 0 100%
/app/errors/errors.py 5 5 0%
/app/extensions.py 3 0 100%
/app/helpers.py 71 27 62%
/app/main/init.py 7 1 86%
/app/main/routes.py 127 14 89%
/app/tasks/init.py 10 2 80%
/app/tasks/helpers.py 11 4 64%
/app/tasks/tasks.py 34 0 100%
TOTAL 406 59 85%
======================= 35 passed, 45

This will help in the case of users asking for data that's already been deleted
@johnpeart
Copy link
Collaborator

We have a 404 page on the main website, here:
https://github.com/civilservicelgbt/magenta/blob/main/_layouts/four-oh-four.html

Does that work?

@jonodrew
Copy link
Owner Author

jonodrew commented Jun 25, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants