Conversation
Owner
Author
|
Better late than never, some error handling! @johnpeart is there a pre-existing 404 error page we can re-use for this? |
✅ Result of Pytest Coverage---------- coverage: platform linux, python 3.9.13-final-0 -----------
|
This will help in the case of users asking for data that's already been deleted
Collaborator
|
We have a 404 page on the main website, here: Does that work? |
Owner
Author
|
That looks great! Then I think it'll just be a matter of copy-pasting it
into this repo
…On Sat, 25 Jun 2022, 21:25 John Peart, ***@***.***> wrote:
We have a 404 page on the main website, here:
https://github.com/civilservicelgbt/magenta/blob/main/_layouts/four-oh-four.html
Does that work?
—
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2ATLUXF4RZMQFLJGCC46DVQ5TM3ANCNFSM5Z2I4HYA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help in the case of users asking for data that's already been deleted