Claude/fix multiline import 2 h29 m #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove ruff from apt (not available) and install via pip instead - Add Python 3.12 installation (required for Django 6.0+) - Create Python 3.12 virtual environment for isolation - Reorder pip install before setup.sh (NLTK needs packages installed first) - Install requirements.txt, requirements-dev.txt, and ruff in venv
The process_media_batch task was using settings.STASHCAST_DEFAULT_YTDLP_ARGS which doesn't exist. Only _AUDIO and _VIDEO variants are defined. Fix by using get_ytdlp_args_for_type(resolved_type) helper which returns the appropriate args based on media type.
Add BatchProcessingSettingsTest to verify: - process_media_batch imports successfully (catches undefined settings) - get_ytdlp_args_for_type helper returns valid values - All settings used by batch processing exist This would catch the undefined STASHCAST_DEFAULT_YTDLP_ARGS bug.
- Add demo_data/transcode-test/audio.ogg test file - Add TranscodingE2ETest that verifies OGG files are transcoded to M4A - This exercises the actual ffmpeg transcoding code path The test would have caught the undefined STASHCAST_DEFAULT_YTDLP_ARGS bug if transcoding was involved in batch processing.
The command does more than transcoding - it downloads via yt-dlp/HTTP and only transcodes if needed. 'fetch' better describes its purpose. - Rename transcode.py to fetch.py - Update help text to clarify it's standalone (not added to feed) - Rename docs/TRANSCODE_COMMAND.md to docs/FETCH_COMMAND.md - Update all documentation references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.