[Enhancement] chaining for all properties of shapes

[datacurse]

Right now i have to assign props like stroke and linewidth on new lines like this:

const borderRect = new Two.Rectangle(x, y, w - borderWidth, h - borderWidth)
    .noFill();
  borderRect.stroke = '#E3E7EA';
  borderRect.linewidth = borderWidth;

I would like them to be chainable, just like how we chain .noFill():

const borderRect = new Two.Rectangle(x, y, w - borderWidth, h - borderWidth)
    .noFill()
    .stroke('#E3E7EA')
    .linewidth(borderWidth);

I wonder if it was not implemented due to some technical restriction, and if not i think it would be a very nice sugar for this library ^^

[jonobr1]

Thanks for posting! In the meantime, if you’re applying lots of changes on construction of an object you can use: const rect = Two.Rectanle.fromObject(props) and pass in an object with all the properties you wanna change.

I know it’s not the same, but all the classes have this static method.

[datacurse]

oh, interesting indeed, thank you a lot!

[datacurse]

can you please give me an example of working Two.Circle.fromObject({...})? i keep getting weird ts error: TypeError: Cannot read properties of undefined (reading 'type')

[jonobr1]

There was a bug in the class that all objects inherit from. This should be fixed in the latest version: v0.8.20 which I just published to npm. Sorry about that!

[datacurse]

Thank you!

[datacurse]

Hi! i updated to v0.8.20, now i get this error when trying to create rectangle from object:

Cannot read properties of undefined (reading 'length')

same with circle

[jonobr1]

Mind sharing the object you're passing?

[datacurse]

const body = Two.Circle.fromObject({
            x: 10,
            y: 10,
            radius: 10,
            fill: "#3aa3ff",
            stroke: "#0a5fbf",
            linewidth: 2
          });

something like this

[datacurse]

would be cool to have some examples in docs for creating from object.

[datacurse]

also typing for creation from object would also be nice. Right now i have to blind guess what attributes shape has

[datacurse]

i think i found the issue. If vertices is not present it will throw this Cannot read properties of undefined (reading 'length') error.