Skip to content

feat(shell): add new feature and tests for default and minimal scenarios #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 27, 2025
Merged

feat(shell): add new feature and tests for default and minimal scenarios #22

merged 18 commits into from
Apr 27, 2025

Conversation

@jonmatum
Copy link
Owner

@jonmatum jonmatum commented Apr 26, 2025 •
edited
Loading

Summary

This PR refactors the Shell feature to ensure compatibility across multiple base images, and adds automated tests to prevent regressions.

Details

  • Refactored Shell feature to explicitly support and validate against different Linux base images:
    • amazonlinux:2023
    • debian:latest
    • mcr.microsoft.com/devcontainers/base:ubuntu
    • ubuntu:latest
  • Expanded scenarios.json to define testing scenarios for each supported base image.
  • Added coverage for:
    • Full default shell installation (zsh + Oh My Zsh + powerlevel10k + plugins)
    • Minimal shell installation (zsh-only setup)
  • Ensures that future changes will not accidentally break:
    • Zsh installation
    • Oh My Zsh setup
    • Theme configuration (powerlevel10k)
    • Plugins (autosuggestions, syntax highlighting)

Why

  • Improve the reliability of the Shell feature across various environments.
  • Catch compatibility issues early via CI.
  • Support a broader range of user needs by guaranteeing multi-distro compatibility.

@jonmatum
feat(shell): add new feature and tests for default and minimal scenarios
14c84ab 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum jonmatum self-assigned this Apr 26, 2025
jonmatum added 17 commits April 26, 2025 16:15
@jonmatum
fix(shell): update feature file name
bea61ba 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
fix(shell): polish devcontainer-feature.json metadata and descriptions
bca3c60 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
test: add minimal shell scenario validation
eee87b3 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
chore: improve automated documentation PR to follow conventional commits
e3514d3 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
test(shell): add validation for minimal zsh setup without oh-my-zsh
77181fc 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
test(ci): add Amazon Linux 2023 to base image matrix for feature testing
30b0fa6 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
fix(shell): dynamically install git before shell setup to ensure full…
b277ef5 
… cross-platform support

Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
fix(shell): ensure .zshrc exists before updating it to prevent missin…
90b57f8 
…g file errors

Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
test(shell): ensure .zshrc exists before updating it to prevent missi…
23f1e9e 
…ng file errors

Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
fix(shell): correctly handle root user's home directory
85ea32a 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
fix(shell): safely source feature-utils.sh if available
3644a0a 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
fix(shell): ensure plugins and themes install only if Oh My Zsh is en…
359af56 
…abled

Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
feat(shell): only install oh-my-zsh and plugins if zsh is installed
ef5cd9e 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
feat(shell): finalize robust Zsh and Oh My Zsh setup
8d21c5a 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
test(shell): install
fcaeb51 
Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
test(scenarios): add scenarios for amazonlinux, debian, ubuntu base i…
d7b73b4 
…mages

Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum
test(scenarios): add scenarios for amazonlinux, debian, ubuntu base i…
e133792 
…mages

Signed-off-by: Jonatan Mata <jonmatum@gmail.com>
@jonmatum jonmatum merged commit b6bb18f into main Apr 27, 2025
7 checks passed
@jonmatum jonmatum deleted the feat/shell branch April 27, 2025 22:09
This was referenced Apr 27, 2025
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jonmatum jonmatum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonmatum