implement AddZoneRecord #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonlil
force-pushed
the
add-zone-record
branch
from
af75aea to
5938748
Compare
jonlil
commented
Nov 4, 2018
dns.go
Outdated
| element.ID = 0 | ||
|
|
||
| // Compare by value | ||
| if *&element == *record { |
There was a problem hiding this comment.
is this bad practice? @akarl818
There was a problem hiding this comment.
Looks fine. Although wouldn't element == *record be the same thing?
There was a problem hiding this comment.
That looks a lot simpler! Thanks for the suggestion
jonlil
force-pushed
the
add-zone-record
branch
from
5938748 to
6505d42
Compare
akarl
approved these changes
Nov 4, 2018
dns.go
Outdated
| element.ID = 0 | ||
|
|
||
| // Compare by value | ||
| if *&element == *record { |
There was a problem hiding this comment.
Looks fine. Although wouldn't element == *record be the same thing?
jonlil
force-pushed
the
add-zone-record
branch
from
fe7d6ca to
7eb1537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.