chore(package.json): Remove --fix from lint script (and CI), add lint…

…:fix script for human use (patternfly#308)

Including --fix in the lint script run by CI means that any errors fixable by that will not fail CI,
and will get checked in.

package.json

@@ -112,7 +112,10 @@
     "build:scripts": "babel src --out-dir dist/js --ignore .test.js,__mocks__",
     "build:less": "mkdir -p dist/less && cp -r less/* dist/less",
     "build:sass": "mkdir -p dist/sass && cp -r sass/patternfly-react/* dist/sass && node-sass --output-style compressed --include-path sass --include-path $npm_package_sassIncludes_patternfly --include-path $npm_package_sassIncludes_bootstrap --include-path $npm_package_sassIncludes_fontAwesome -o dist/css sass/patternfly-react.scss",
-    "lint": "eslint --rulesdir lint-rules/ --fix --max-warnings 0 src storybook && yarn stylelint",
+    "lint": "yarn lint:js && yarn lint:styles",
+    "lint:fix": "yarn lint:js --fix && yarn lint:styles --fix",
+    "lint:js": "eslint --rulesdir lint-rules/ --max-warnings 0 src storybook",
+    "lint:styles": "yarn stylelint",
     "prettier": "prettier --write --single-quote --trailing-comma=none '{src,storybook}/**/*.js'",
     "prepare": "yarn build",
     "test": "yarn lint && jest",
@@ -143,4 +146,4 @@
   "czConfig": {
     "path": "node_modules/cz-conventional-changelog"
   }
-}
+}

src/components/Filter/FilterActiveLabel.js

@@ -4,7 +4,11 @@ import PropTypes from 'prop-types';
 
 const FilterActiveLabel = ({ children, className, ...props }) => {
   const classes = classNames('filter-pf-active-label', className);
-  return <p className={classes} {...props}>{children}</p>;
+  return (
+    <p className={classes} {...props}>
+      {children}
+    </p>
+  );
 };
 
 FilterActiveLabel.propTypes = {

src/components/Filter/FilterItem.js

@@ -4,7 +4,13 @@ import PropTypes from 'prop-types';
 import { noop } from '../../common/helpers';
 import { DisposableLabel } from '../Label';
 
-const FilterItem = ({ children, className, onRemove, filterData, ...props }) => {
+const FilterItem = ({
+  children,
+  className,
+  onRemove,
+  filterData,
+  ...props
+}) => {
   const classes = classNames(className);
 
   return (

src/components/ListView/ListView.stories.js

@@ -57,7 +57,14 @@ stories.add(
     <ListView>
       {mockListItems.map(
         (
-          { actions, properties, title, description, expandedContentText, hideCloseIcon },
+          {
+            actions,
+            properties,
+            title,
+            description,
+            expandedContentText,
+            hideCloseIcon
+          },
           index
         ) => (
           <ListView.Item

src/components/Sort/SortTypeSelector.js

@@ -23,7 +23,12 @@ const SortTypeSelector = ({
     }
 
     return (
-      <DropdownButton className={className} title={title} id={menuId} {...props}>
+      <DropdownButton
+        className={className}
+        title={title}
+        id={menuId}
+        {...props}
+      >
         {sortTypes.map((item, index) => {
           const classes = {
             selected: item === currentSortType

src/components/Wizard/WizardReviewStep.js

@@ -6,7 +6,13 @@ import { noop } from '../../common/helpers';
 /**
  * WizardReviewStep component for Patternfly React
  */
-const WizardReviewStep = ({ children, onClick, title, collapsed, ...props }) => (
+const WizardReviewStep = ({
+  children,
+  onClick,
+  title,
+  collapsed,
+  ...props
+}) => (
   <ListGroupItem listItem {...props}>
     <a href="#" onClick={onClick} className={collapsed ? 'collapsed' : ''}>
       {title}