-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for Firefox bug: clear viewbox later #242
Conversation
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
=======================================
Coverage 87.21% 87.21%
=======================================
Files 18 18
Lines 2527 2527
=======================================
Hits 2204 2204
Misses 323 323 Continue to review full report at Codecov.
|
Huh, very interesting. I wonder if this'd be better suited to go in the |
Other points, beyond the location:
I'm trying to remember if I tried it in setTimeout. Possibly not. But there are definitely some rendering race conditions in there that mean setTimeout might not work, will try. |
Just validated that disabling quirks mode in my HTML page does not fix the original bug. |
And Safari seems happy regardless, both with and without the fix. |
Moving to setTimeout seems to also fix the Firefox problem, so I will update PR. |
(Going to do a bit more manual testing even after I push the change, I'll let you know when I'm completely convinced.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you!
Release in 0.11.4 🎉 |
Fixes #241