-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move details bar to top in icicle mode. #177
Conversation
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 16 16
Lines 2223 2232 +9
==========================================
+ Hits 2006 2014 +8
- Misses 217 218 +1
Continue to review full report at Codecov.
|
Guess I should write a unit test too. |
BTW, just realized you're in Cambridge, MA too. Could I get you to sign and share https://bit.ly/3eNdnhK? We're trying to hit 1000 people by the time we submit it tomorrow 😁 |
I'm not currently in a position to test this, but I assume you have tested that both old and new flamegraphs still work? :p |
Yeah. I can try to upload the results... |
Looks great, thank you! |
Fixes #176.