Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nameattr an optional feature #147

Merged
merged 2 commits into from
Sep 11, 2019
Merged

Make nameattr an optional feature #147

merged 2 commits into from
Sep 11, 2019

Conversation

jasonrhansen
Copy link
Collaborator

This makes indexmap an optional dependency.

jonhoo
jonhoo approved these changes Sep 11, 2019
View reviewed changes
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jasonrhansen jasonrhansen merged commit ce4ca10 into jonhoo:master Sep 11, 2019
@jonhoo
Copy link
Owner

jonhoo commented Sep 11, 2019

Released in 0.9.0 🚀

@jasonrhansen jasonrhansen mentioned this pull request Sep 11, 2019
Open
@jasonrhansen jasonrhansen deleted the nameattr-feature-flag branch September 13, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonrhansen @jonhoo