Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current CI #123

Merged
merged 4 commits into from
Apr 14, 2019
Merged

Fix current CI #123

merged 4 commits into from
Apr 14, 2019

Conversation

AnderEnder
Copy link
Contributor

@AnderEnder AnderEnder commented Apr 13, 2019

Looks like windows target on travis is unstable again(could be related to the last rust release).

  • Temporary allow windows target to fails.
  • Fix clippy flag
  • Fix new clippy warnings

@jonhoo
Copy link
Owner

jonhoo commented Apr 13, 2019

Would you mind leaving a comment above the added line with a link to this PR?

@codecov-io
Copy link

codecov-io commented Apr 13, 2019

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is 60%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files          12       12           
  Lines        1341     1341           
=======================================
  Hits         1202     1202           
  Misses        139      139
Impacted Files Coverage Δ
src/flamegraph/mod.rs 95.73% <ø> (ø) ⬆️
src/flamegraph/color/mod.rs 75.35% <60%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d549ff...b91b19b. Read the comment docs.

@jonhoo
Copy link
Owner

jonhoo commented Apr 13, 2019

What are the other f32 changes for?

@AnderEnder
Copy link
Contributor Author

New clippy version starts to show new warnings:

warning: casting integer literal to f32 is unnecessary
   --> src/flamegraph/color/mod.rs:290:15
    |
290 |         $b + ($a as f32 * $x) as u8
    |               ^^^^^^^^^ help: try: `50_f32`
...
314 |         BasicPalette::Hot => color!(t!(205, 50, v3), t!(0, 230, v1), t!(0, 55, v2)),
    |                                     --------------- in this macro invocation
    |
    = note: #[warn(clippy::unnecessary_cast)] on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
...

@AnderEnder AnderEnder changed the title temporary allow windows target to fails Fix current CI Apr 13, 2019
@jonhoo jonhoo merged commit b76aaf9 into jonhoo:master Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants