Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atty 0.2 has a potential unaligned read #278

Closed
djc opened this issue Feb 10, 2023 · 3 comments · Fixed by #280
Closed

atty 0.2 has a potential unaligned read #278

djc opened this issue Feb 10, 2023 · 3 comments · Fixed by #280

Comments

@djc
Copy link
Contributor

djc commented Feb 10, 2023

From cargo deny:

error[unsound]: Potential unaligned read
  ┌─ /Users/djc/src/flamegraph/Cargo.lock:4:1
  │
4 │ atty 0.2.14 registry+https://github.com/rust-lang/crates.io-index
  │ ----------------------------------------------------------------- unsound advisory detected
  │
  = ID: RUSTSEC-2021-0145
  = Advisory: https://rustsec.org/advisories/RUSTSEC-2021-0145
  = On windows, `atty` dereferences a potentially unaligned pointer.
    
    In practice however, the pointer won't be unaligned unless a custom global allocator is used.
    
    In particular, the `System` allocator on windows uses `HeapAlloc`, which guarantees a large enough alignment.
    
    # atty is Unmaintained
    
    A Pull Request with a fix has been provided over a year ago but the maintainer seems to be unreachable.
    
    Last release of `atty` was almost 3 years ago.
    
    ## Possible Alternative(s)
    
    The below list has not been vetted in any way and may or may not contain alternatives;
    
     - [is-terminal](https://crates.io/crates/is-terminal)
     - std::io::IsTerminal *nightly-only experimental*
  = Announcement: https://github.com/softprops/atty/issues/50
  = Solution: No safe upgrade is available!
  = atty v0.2.14
    └── inferno v0.11.14
        └── flamegraph v0.6.2
@djc
Copy link
Contributor Author

djc commented Feb 10, 2023

I think tracing-subscriber switched to nu-ansi-term. There is also an is_terminal crate, which I guess does everything you need here.

jonhoo added a commit that referenced this issue Feb 11, 2023
@jonhoo
Copy link
Owner

jonhoo commented Feb 11, 2023

Moved to is-terminal in #280

@djc
Copy link
Contributor Author

djc commented Feb 11, 2023

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants