Disable the hyper http2 feature #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good call. Should we even include http2 support at all? Is it actually supported (or more importantly, required) for any WebDriver servers? |
|
I'm not sure. The http2 feature was enabled in commit 715a711. I guess it was either done to explicitly get HTTP/2 enabled or to work around rustls/hyper-rustls#141 |
|
That's a very good question. @x0f5c3 can you shed some light on the use of the |
|
I think it was done to work around the rustls issue, if it was fixed I guess it could be disabled since AFAIK WebDriver protocol doesn't use HTTP2 |
paolobarbolini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since you're going to release a minor version anyway I wouldn't mind having the ability to reduce
hyper's dependencies.Makes the
http2feature optional and enables it by default.