Fix #760: Capture Apex cursor limits

[vikashkrml]

Created new fields for Apex cursor limits, Added logic to Capture Apex cursor limits, updated permission sets, updated Test classes

[jongpie]

@vikashkrml thanks so much for working on this! I did a quick preliminary review, and overall this looks really great. I'm hoping that later this week, I'll be able to do a more thorough review - I'll keep you updated on my progress!

[vikashkrml]

@jongpie Thank you.
Sure, take your time.

[jongpie]

@vikashkrml I've pushed some additional commits to your branch. Overall your changes look awesome, I just made a few clean-up changes, including:

• Slightly renamed some of the new field for clarity
• Moved around some code for consistency
• Added some formula fields on LogEntry__c (similar to the other limits formula fields on LogEntry__c)

I'll do one more round of review/testing just to be safe, but my hope is to merge this tomorrow. If you have any questions/comments about the changes I made, let me know!

[vikashkrml]

@jongpie Thanks for reviewing and pushing the additional commits!
The changes you made look great — I especially like the improved field naming and the added formula fields on LogEntry__c. Everything looks clear on my end, so I don’t have any questions at the moment.

Appreciate the extra round of testing before merge! 🚀

[jongpie]

Thanks @vikashkrml for the feedback! I did another review today, and after looking at the field names some more, I decided to slightly rename the fetch calls fields as well. You named them consistently with the Limits methods, which I 100% appreciate the consistency - but in this case, I dislike how Salesforce has named the methods in the Limits class, so I've adjusted the names for the fields to be (what I think is) a little bit clearer

• LimitsFetchCallsOnApexCursorUsed__c fields ➡️ renamed to LimitsApexCursorFetchCallsUsed__c
• LimitsFetchCallsOnApexCursorMax__c fields ➡️ renamed to LimitsApexCursorFetchCallsMax__c

With those changes, all of the new Apex cursor fields now have a consistent naming convention within Nebula Logger (even if it differs a bit from the method names in the Limits class):

1. LimitsApexCursorFetchCallsUsed__c
2. LimitsApexCursorFetchCallsMax__c
3. LimitsApexCursorRowsUsed__c
4. LimitsApexCursorRowsMax__c

Here's a screenshot showing the end result via the 2 LogEntry__c formula fields LimitsApexCursorFetchCalls__c and LimitsApexCursorRows__c:

I think this is the last change I'll make 😅, I'm going to try to merge & release this later today!

Thanks again for all of your help with this!

[jongpie]

Alright, this is now available in release v4.16.5 - thanks again for your help @vikashkrml!

[vikashkrml]

Thanks @jongpie for the update and for explaining the renaming decision — that makes total sense 👍. I agree the new names are much clearer and having everything aligned within Nebula Logger definitely improves readability.

Really glad to see this merged and released in v4.16.5 🎉. Thanks for walking me through the review process and for refining the changes along the way!

I’d be happy to contribute more in the future as well.

Thanks again! 🙌