Skip to content

Commit

Permalink
Code style and syntax clean up (Azure#18445)
Browse files Browse the repository at this point in the history
* Code style and syntax clean up

* regenrate the code.

Co-authored-by: Azad Abbasi <azabbasi@microsoft.com>
  • Loading branch information
2 people authored and jongio committed Feb 9, 2021
1 parent 8eb8308 commit 9b0c10d
Show file tree
Hide file tree
Showing 7 changed files with 320 additions and 227 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ internal partial class DigitalTwinModelsRestClient
{
// The modelUpdates parameter needs to be changed from IEnumerable<object> to IEnumerable<string>
// and not parsed like a json object.
internal async Task<Response<IReadOnlyList<DigitalTwinsModelData>>> AddAsync(IEnumerable<string> models = null, CreateModelsOptions digitalTwinModelsAddOptions = null, CancellationToken cancellationToken = default)
internal async Task<Response<IReadOnlyList<DigitalTwinsModelData>>> AddAsync(
IEnumerable<string> models = null,
CreateModelsOptions digitalTwinModelsAddOptions = null,
CancellationToken cancellationToken = default)
{
using DiagnosticScope scope = _clientDiagnostics.CreateScope("DigitalTwinModelsClient.Add");
scope.Start();
Expand All @@ -30,7 +33,9 @@ internal async Task<Response<IReadOnlyList<DigitalTwinsModelData>>> AddAsync(IEn
case 201:
{
IReadOnlyList<DigitalTwinsModelData> value = default;
using JsonDocument document = await JsonDocument.ParseAsync(message.Response.ContentStream, default, cancellationToken).ConfigureAwait(false);
using JsonDocument document = await JsonDocument
.ParseAsync(message.Response.ContentStream, default, cancellationToken)
.ConfigureAwait(false);
List<DigitalTwinsModelData> array = new List<DigitalTwinsModelData>(document.RootElement.GetArrayLength());
foreach (JsonElement item in document.RootElement.EnumerateArray())
{
Expand All @@ -52,7 +57,10 @@ internal async Task<Response<IReadOnlyList<DigitalTwinsModelData>>> AddAsync(IEn

// The modelUpdates parameter needs to be changed from IEnumerable<object> to IEnumerable<string>
// and not parsed like a json object.
internal Response<IReadOnlyList<DigitalTwinsModelData>> Add(IEnumerable<string> models = null, CreateModelsOptions digitalTwinModelsAddOptions = null, CancellationToken cancellationToken = default)
internal Response<IReadOnlyList<DigitalTwinsModelData>> Add(
IEnumerable<string> models = null,
CreateModelsOptions digitalTwinModelsAddOptions = null,
CancellationToken cancellationToken = default)
{
using DiagnosticScope scope = _clientDiagnostics.CreateScope("DigitalTwinModelsClient.Add");
scope.Start();
Expand Down Expand Up @@ -88,7 +96,11 @@ internal Response<IReadOnlyList<DigitalTwinsModelData>> Add(IEnumerable<string>

// The modelUpdates parameter needs to be changed from IEnumerable<object> to IEnumerable<string>
// and not parsed like a json object.
internal async Task<Response> UpdateAsync(string id, IEnumerable<string> modelUpdates, DecomissionModelOptions digitalTwinModelsUpdateOptions = null, CancellationToken cancellationToken = default)
internal async Task<Response> UpdateAsync(
string id,
IEnumerable<string> modelUpdates,
DecommissionModelOptions digitalTwinModelsUpdateOptions = null,
CancellationToken cancellationToken = default)
{
if (id == null)
{
Expand Down Expand Up @@ -120,7 +132,11 @@ internal async Task<Response> UpdateAsync(string id, IEnumerable<string> modelUp

// The modelUpdates parameter needs to be changed from IEnumerable<object> to IEnumerable<string>
// and not parsed like a json object.
internal Response Update(string id, IEnumerable<string> modelUpdates, DecomissionModelOptions digitalTwinModelsUpdateOptions = null, CancellationToken cancellationToken = default)
internal Response Update(
string id,
IEnumerable<string> modelUpdates,
DecommissionModelOptions digitalTwinModelsUpdateOptions = null,
CancellationToken cancellationToken = default)
{
if (id == null)
{
Expand Down Expand Up @@ -182,7 +198,7 @@ private HttpMessage CreateAddRequest(IEnumerable<string> models, CreateModelsOpt

// The strings are already json, so we do not want them to be serialized.
// Instead, the payloads need to be concatenated into a json array.
private HttpMessage CreateUpdateRequest(string id, IEnumerable<string> modelUpdates, DecomissionModelOptions digitalTwinModelsUpdateOptions)
private HttpMessage CreateUpdateRequest(string id, IEnumerable<string> modelUpdates, DecommissionModelOptions digitalTwinModelsUpdateOptions)
{
var message = _pipeline.CreateMessage();
var request = message.Request;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ internal async Task<Response<Stream>> AddAsync(
}
case 202:
return Response.FromValue<Stream>(null, message.Response);

default:
throw await _clientDiagnostics.CreateRequestFailedExceptionAsync(message.Response).ConfigureAwait(false);
}
Expand All @@ -90,7 +91,11 @@ internal async Task<Response<Stream>> AddAsync(
}
}

internal Response<Stream> Add(string id, Stream twin, CreateOrReplaceDigitalTwinOptions digitalTwinsAddOptions = null, CancellationToken cancellationToken = default)
internal Response<Stream> Add(
string id,
Stream twin,
CreateOrReplaceDigitalTwinOptions digitalTwinsAddOptions = null,
CancellationToken cancellationToken = default)
{
if (id == null)
{
Expand All @@ -112,6 +117,7 @@ internal Response<Stream> Add(string id, Stream twin, CreateOrReplaceDigitalTwin
}
case 202:
return Response.FromValue<Stream>(null, message.Response);

default:
throw _clientDiagnostics.CreateRequestFailedException(message.Response);
}
Expand Down Expand Up @@ -760,10 +766,10 @@ private HttpMessage CreateUpdateRequest(
}

private HttpMessage CreateAddRelationshipRequest(
string id,
string relationshipId,
Stream relationship,
CreateOrReplaceRelationshipOptions digitalTwinsAddRelationshipOptions)
string id,
string relationshipId,
Stream relationship,
CreateOrReplaceRelationshipOptions digitalTwinsAddRelationshipOptions)
{
HttpMessage message = _pipeline.CreateMessage();
Request request = message.Request;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace Azure.DigitalTwins.Core
{
/// <inheritdoc />
[CodeGenModel("DigitalTwinModelsUpdateOptions")]
internal partial class DecomissionModelOptions
internal partial class DecommissionModelOptions
{
// This class declaration changes the namespace, class name and property visibility; do not remove.

Expand Down
Loading

0 comments on commit 9b0c10d

Please sign in to comment.