Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Update GitHub actions #758

Merged
merged 4 commits into from
May 3, 2024

Conversation

gtdang
Copy link
Collaborator

@gtdang gtdang commented Apr 30, 2024

Runners were no longer finding the conda base version preventing gh runners to build.

  • Updating the setup-miniconda line to version 3 seemed to fix the problem.
  • Updated the checkout action to v4.
  • Changed fetch-depth to 2 because it was stalling on codecov step on linux runners. source
  • Updated to use codecov upload action v4 instead of shell command

setup-miniconda
checkout

@gtdang gtdang changed the title Update GitHub actions [WIP] Update GitHub actions Apr 30, 2024
@gtdang gtdang marked this pull request as ready for review April 30, 2024 20:09
@gtdang
Copy link
Collaborator Author

gtdang commented Apr 30, 2024

@ntolley @jasmainak @rythorpe
I will need to work with someone who has access to the codecov token to set-up the secret for the repository. Can someone meet with me tomorrow for this?

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (d28ddb7) to head (c167263).
Report is 32 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
+ Coverage   92.67%   92.69%   +0.02%     
==========================================
  Files          27       27              
  Lines        4928     4969      +41     
==========================================
+ Hits         4567     4606      +39     
- Misses        361      363       +2     
Flag Coverage Δ
unittests 92.69% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gtdang
Copy link
Collaborator Author

gtdang commented May 1, 2024

@ntolley @jasmainak @rythorpe I will need to work with someone who has access to the codecov token to set-up the secret for the repository. Can someone meet with me tomorrow for this?

Actually we don't need to meet for this if one of you can do it following these directions. Note the token is needed for PRs that come from within the org. It switches to token-less uploading if the PR is coming from a forked repository. See more information here.

@jasmainak
Copy link
Collaborator

I'll try to help if I can find a moment tomorrow ...

@gtdang gtdang changed the title [WIP] Update GitHub actions [MRG] Update GitHub actions May 3, 2024
Copy link
Contributor

@ntolley ntolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasmainak looks like we need access to the jonescompneurolab account to get the secret generated by codecov.

In any case this PR doesn't really depend on that update so I'm going to go ahead and merge.

@ntolley ntolley merged commit 0346dbf into jonescompneurolab:master May 3, 2024
9 checks passed
This was referenced May 6, 2024
@gtdang gtdang deleted the update-gh-actions branch August 29, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants