Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't expose string extension #584

Merged
merged 1 commit into from
Aug 26, 2023
Merged

fix: Don't expose string extension #584

merged 1 commit into from
Aug 26, 2023

Conversation

lsaudon
Copy link
Contributor

@lsaudon lsaudon commented Aug 22, 2023

Do not expose the extension used for the package.
If you're not careful, you could use it in your code and make it dependent on the package.

@jonbhanson
Copy link
Owner

Thanks @lsaudon!

@jonbhanson jonbhanson merged commit 5387581 into jonbhanson:master Aug 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants