Plugin speedup! 🚅 #558
Merged
Plugin speedup! 🚅 #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated README.md and CHANGELOG.md with new changes
vlazdra
commented
May 23, 2023
jonbhanson
requested changes
May 28, 2023
There was a problem hiding this comment.
@vlazdra great work on this PR! This is an excellent improvement to the package. I have a few comments before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jonbhanson!
I recently started with a white-label project, and integrated your plugin in a CI/CD pipeline.
The thing that caught my eye is the time that is needed to generate all the assets when running the command
in a white-label project. So wanted to contribute again like with the flavors integration! 🙌
There are 2 things in this PR, both mentioned in the README.md and the CHANGELOG.md
Let's go backwards, the plural of the flavor command --flavors -- a comma separated list of all the flavors that the developer has setup in the project (just for ease of use). So instead of running the command 3 times, you just specify all the flavors and the plugin takes care of the rest.
The second change is the most fun one, the speed up of the execution time of the generating process. 🙌
Please note that I tested this inside my project with 3 flavors set up only for Android and iOS (mobile is only supported either way).
Here are my execution times
That's approximately a 4x speed increase! 🚄 🚄 🚄
Just by leveraging Dart Isolates and generated every image in it's own thread, the speed improvement is awesome!
Looking forward for your feedback!