Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define STRICT_R_HEADERS, include float.h #1

Closed
wants to merge 1 commit into from

Conversation

eddelbuettel
Copy link

Dear Jonathan,

Your CRAN package blatent uses Rcpp, and is affected if we add a definition of STRICT_R_HEADERS as we would like to do. Please see the discussion at
RcppCore/Rcpp#1158
and the links therein for more context on this.

Here, I prefixed two #include <Rcpp.h> with STRICT_R_HEADERS which is slightly more extensive then we need to, but it ensures we will not get surprised later. If you prefer, we can remove one in this PR. The one change that is needed is the change to also (explicitly) #include <float.h> so that DBL_EPSILON is defined (which seemingly to longer happens automatically when setting STRICT_R_HEADERS. No other changes were made.

It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by
RcppCore/Rcpp#1158
to confirm?

Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.

@jonathantemplin
Copy link
Owner

Adding to another pull, so closing this one (but incorporating into files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants