-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options menu upgrade #130
Options menu upgrade #130
Conversation
Added more keys to the translation file and rebinding menu
@NancokPS2 can you rebase? Thx |
Done, there where two conflicts on a single file and that was that, some divine intervention right there. |
Thanks for your PR again. Issues:
Question:
|
Tooltip delay affects the time it takes for a tooltip to appear whenever you hover over a Control node (IF they have one set at all, most settings do) I fixed the oddities by having the settings no longer load with the menu and do so at game-start instead. |
Tested it and works nice. Could you change 1 more thing? Can the full screen be true as default? This is the intended size the game should be played in. If you fix this, I will merge it. thx |
Correcting myself: Fullscreen should not be the default setting. I've corrected the behavior so that at default if the fullscreen is not checked the window is not reloaded to windowed mode, which made the game flicker. I also fixed a naming. Will merge now |
Input names no longer show "(Physical)"
The server no longer loads local settings (All server relevant settings should go in the ENV system)
Added ShaderMaterial-based class that automatically chooses a colorblindness shader based on settings
Added several options
I'm not that experienced with graphical options, so i am not sure if the tooltips for them are completely accurate.
Also some of them have no effect at the moment, since we don't actually use lighting nor 3D for much of anything.
Tested by entering the options menu in-game and playing with the settings. All of them do as they say and are saved locally.
(Crossed out items have been added)
Considerations for future PRs:
Button to open the local save folderActual functionality for importing languages during run-time.From Kashan's
Colorblind/Accessibility options (longer term project/goal probably)(somewhat done)Toggle Hud (screenshot mode)