Skip to content

Add csharpier to CI #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanalgar merged 2 commits into from
Jan 14, 2025
Merged

Add csharpier to CI #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b2d890
add to ci
jonathanalgar Jan 14, 2025
e0f663f
apply csharpier
jonathanalgar Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,12 @@ jobs:
run: |
dotnet tool install --global dotnet-sonarscanner
dotnet tool install --global dotnet-coverage
dotnet tool install --global csharpier
echo "$HOME/.dotnet/tools" >> $GITHUB_PATH


- name: Check code formatting
run: dotnet csharpier --check .

- name: Begin SonarCloud analysis
run: dotnet sonarscanner begin /k:"jonathanalgar_CustomCode-Analyzer" /o:"jonathanalgar" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.cs.vscoveragexml.reportsPaths=coverage.xml

Expand Down
12 changes: 12 additions & 0 deletions config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"version": 1,
"isRoot": true,
"tools": {
"csharpier": {
"version": "[0.30.6]",
"commands": [
"dotnet-csharpier"
]
}
}
}
2 changes: 1 addition & 1 deletion src/CustomCode-Analyzer/Helpers/TypeMappingHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ internal enum OSDataType
PhoneNumber,
Email,
BinaryData,
Currency
Currency,
}

/// <summary>
Expand Down
3 changes: 2 additions & 1 deletion tests/CustomCode-Analyzer.Tests/AnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1302,7 +1302,8 @@ public struct TestStruct
[TestMethod]
public async Task UnsupportedTypeMappingRule_InGlobalScope_InferredFromDotNetType_NoDiagnostic()
{
var source = @"
var source =
@"
[OSStructure]
public struct TestStruct
{
Expand Down