Added support for confirmation keyword + Setup Prettier #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes jonatanklosko#57 The following options have been added: - confirmationKeyword - confirmationKeywordTextFieldProps - getConfirmationKeywordPlaceholder If `confirmationKeyword` is provided a TextField is rendered and the confirmation button is disabled. When the contents of the TextField match the value of `confirmationKeyword` then the confirmation button becomes enabled. Additional stories and tests have alse been added for this behavior.
|
Hey @TimMikeladze! Thanks for the PR, a couple tiny comments and we can ship it :) |
|
@jonatanklosko Thanks for the review. I've addressed your comments. |
jonatanklosko
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57
The following options have been added:
getConfirmationKeywordPlaceholderIf
confirmationKeywordis provided a TextField is rendered and the confirmation button is disabled. When the contents of the TextField match the value ofconfirmationKeywordthen the confirmation button becomes enabled.Additional stories and tests have also been added for this behavior.
Also Prettier has been configured and formatted the existing codebase. @jonatanklosko If you don't want this specific commit I can resubmit the PR or you can cherry-pick the main commit over.