Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some as casts #809

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Remove some as casts #809

merged 3 commits into from
Dec 25, 2024

Conversation

jonasbb
Copy link
Owner

@jonasbb jonasbb commented Dec 25, 2024

This removes some potential arithmetic issues

See #771 for reference

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 58.62069% with 12 lines in your changes missing coverage. Please review.

Project coverage is 66.40%. Comparing base (abb13ca) to head (c910fa1).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
serde_with/src/utils/duration.rs 57.14% 6 Missing ⚠️
serde_with/src/chrono_0_4.rs 50.00% 4 Missing ⚠️
serde_with/src/de/impls.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
- Coverage   66.55%   66.40%   -0.16%     
==========================================
  Files          40       40              
  Lines        2613     2625      +12     
==========================================
+ Hits         1739     1743       +4     
- Misses        874      882       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasbb jonasbb merged commit 4c273b2 into master Dec 25, 2024
18 checks passed
@jonasbb jonasbb deleted the remove-as-casts branch December 25, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant