Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #778

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix typos #778

merged 1 commit into from
Sep 12, 2024

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Sep 6, 2024

No description provided.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (aaa0a29) to head (378fa24).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   67.32%   67.45%   +0.12%     
==========================================
  Files          40       40              
  Lines        2464     2464              
==========================================
+ Hits         1659     1662       +3     
+ Misses        805      802       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,2 @@
[default.extend-words]
Algorythm = "Algorythm"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this https://crates.io/crates/typos-cli passes without error

happy to add it to the CI if you like

Copy link
Owner

@jonasbb jonasbb Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the configuration yet, but what is the difference to this?

[default.extend-identifiers]
TheAlgorythm = "TheAlgorythm"

@jonasbb
Copy link
Owner

jonasbb commented Sep 12, 2024

This looks good. Thank you for the PR. The typos tool looks interesting. Automating it makes sense too, but I wonder if adding it as a pre-commit hook would work better.

@jonasbb jonasbb merged commit 2a28e46 into jonasbb:master Sep 12, 2024
22 checks passed
@jayvdb jayvdb deleted the typos branch September 25, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants