Fix proc-macros were relying on the prelude to be available #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With no_implicit_prelude even more items are not available for the macros. This revealed the bugs fixed in the previous commit. https://doc.rust-lang.org/reference/names/preludes.html#the-no_implicit_prelude-attribute
|
Build failed: |
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 78.81% 78.81%
=======================================
Files 41 41
Lines 2483 2483
=======================================
Hits 1957 1957
Misses 526 526
Continue to review full report at Codecov.
|
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly name all types and traits in the derive macros such that they do not conflict with the environment where they are used.
bors r+