Skip to content

Commit

Permalink
Merge #653
Browse files Browse the repository at this point in the history
653: Decrease minimum serde version to 1.0.152 r=jonasbb a=banool

As far as I can tell, the minimum version of 1.0.157 is unnecessary. The way I've determined that is just from running the build + tests:
```
cargo build --workspace
cargo test --workspace
```

This addresses #651. For my needs at least 1.0.152 is actually sufficient (rather than 1.0.149), though we could try go lower.


Co-authored-by: Daniel Porteous <daniel@dport.me>
  • Loading branch information
bors[bot] and banool authored Oct 14, 2023
2 parents 04bf8f3 + 81507a2 commit f55d41d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion serde_with/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ indexmap_1 = {package = "indexmap", version = "1.8", optional = true, default-fe
indexmap_2 = {package = "indexmap", version = "2.0", optional = true, default-features = false, features = ["serde"]}
# The derive feature is needed for the flattened_maybe macro.
# https://github.com/jonasbb/serde_with/blob/eb1965a74a3be073ecd13ec05f02a01bc1c44309/serde_with/src/flatten_maybe.rs#L67
serde = {version = "1.0.157", default-features = false, features = ["derive"] }
serde = {version = "1.0.152", default-features = false, features = ["derive"] }
serde_json = {version = "1.0.45", optional = true, default-features = false}
serde_with_macros = {path = "../serde_with_macros", version = "=3.3.0", optional = true}
time_0_3 = {package = "time", version = "~0.3.11", optional = true, default-features = false}
Expand Down
2 changes: 1 addition & 1 deletion serde_with_macros/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ version = "2.0.0"
expect-test = "1.4.0"
pretty_assertions = "1.4.0"
rustversion = "1.0.0"
serde = {version = "1.0.157", features = ["derive"]}
serde = {version = "1.0.152", features = ["derive"]}
serde_json = "1.0.25"
trybuild = "1.0.80"
version-sync = "0.9.1"
Expand Down

0 comments on commit f55d41d

Please sign in to comment.