Skip to content

Cleanup some oversights while migrating to the newer petgraph #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

Cleanup some oversights while migrating to the newer petgraph #19

merged 1 commit into from
Feb 4, 2020

Conversation

@jonasbb
Copy link
Owner

@jonasbb jonasbb commented Feb 4, 2020

  • Use 2018 edition
  • Make version-sync a dev dependency to remove unnecessary dependencies

@jonasbb
Cleanup some oversights while migrating to the newer petgraph
9488ca5 
* Use 2018 edition
* Make version-sync a dev dependency to remove unnecessary dependencies
@jonasbb
Copy link
Owner Author

jonasbb commented Feb 4, 2020

bors r+

bors bot added a commit that referenced this pull request Feb 4, 2020
@bors @jonasbb
Merge #19
4e48005 
19: Cleanup some oversights while migrating to the newer petgraph r=jonasbb a=jonasbb


* Use 2018 edition
* Make version-sync a dev dependency to remove unnecessary dependencies

Co-authored-by: Jonas Bushart <jonas@bushart.org>
@bors
Copy link
Contributor

bors bot commented Feb 4, 2020

Build failed

  • Build and Test (ubuntu-latest, 1.36.0)
  • Build and Test (ubuntu-latest, beta)
  • Build and Test (ubuntu-latest, nightly)
  • Build and Test (ubuntu-latest, stable)
  • Build and Test (windows-latest, 1.36.0)
  • Build and Test (windows-latest, beta)
  • Build and Test (windows-latest, nightly)
  • Build and Test (windows-latest, stable)

@jonasbb
Copy link
Owner Author

jonasbb commented Feb 4, 2020

bors r+

bors bot added a commit that referenced this pull request Feb 4, 2020
@bors @jonasbb
Merge #19
ea5820d 
19: Cleanup some oversights while migrating to the newer petgraph r=jonasbb a=jonasbb


* Use 2018 edition
* Make version-sync a dev dependency to remove unnecessary dependencies

Co-authored-by: Jonas Bushart <jonas@bushart.org>
@codecov
Copy link

codecov bot commented Feb 4, 2020 •
edited
Loading

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files           3        3           
  Lines         151      151           
=======================================
  Hits          140      140           
  Misses         11       11
Impacted Files Coverage Δ
tests/graphml.rs 100% <ø> (ø) ⬆️
src/lib.rs 87.91% <0%> (ø) ⬆️
tests/version_numbers.rs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c438b9...9488ca5. Read the comment docs.

@bors
Copy link
Contributor

bors bot commented Feb 4, 2020

Build succeeded

  • Build and Test (ubuntu-latest, 1.36.0)
  • Build and Test (ubuntu-latest, beta)
  • Build and Test (ubuntu-latest, nightly)
  • Build and Test (ubuntu-latest, stable)
  • Build and Test (windows-latest, 1.36.0)
  • Build and Test (windows-latest, beta)
  • Build and Test (windows-latest, nightly)
  • Build and Test (windows-latest, stable)
  • clippy "All Features" (ubuntu-latest / nightly)
  • clippy "All Features" (ubuntu-latest / stable)
  • clippy "All Features" (windows-latest / nightly)
  • clippy "All Features" (windows-latest / stable)
  • clippy "Default" (ubuntu-latest / nightly)
  • clippy "Default" (ubuntu-latest / stable)
  • clippy "Default" (windows-latest / nightly)
  • clippy "Default" (windows-latest / stable)
  • clippy "No Default Features" (ubuntu-latest / nightly)
  • clippy "No Default Features" (ubuntu-latest / stable)
  • clippy "No Default Features" (windows-latest / nightly)
  • clippy "No Default Features" (windows-latest / stable)
  • Rustfmt (stable)

@bors bors bot merged commit 9488ca5 into master Feb 4, 2020
@bors bors bot deleted the small-cleanup branch February 4, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonasbb