Extract base classes MdnsEmulator and BluetoothEmulator #235
+460
−329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor emulator implementations to eliminate code duplication by extracting common logic into abstract base classes.
Changes
Created
MdnsEmulatorbase classCreated
BluetoothEmulatorbase classRefactored 5 emulator classes
FtmsMdnsEmulator→ extendsMdnsEmulatorOpenBikeControlMdnsEmulator→ extendsMdnsEmulatorZwiftEmulator→ extendsBluetoothEmulatorOpenBikeControlBluetoothEmulator→ extendsBluetoothEmulatorRemotePairing→ extendsBluetoothEmulatorExample
Before:
After:
Impact
awaitkeywords in async notification callsOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.