Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to simulate what happens on software projects: things change and new features are added. In this case the idea is that we're going to add a boolean to
Artwork
calledfeatured
and use that to sort featured artworks to the top of our list endpoint. Our requirements include that only admins should be able to set this field and thus it should not be allowed to be set from the API.In order to do this we start by adding a sort by newest first. Then we add the new property and then update the sort to prioritize featured artworks.
Here
oldest artwork
comes first because it's featured and then the next two follow from that sorted by newest first.The final two commits are adding tests that assert about whether this new field can be set via the API. The ones for Grape fail and demonstrate how it is weak on mass assignment protections by default.