Bugfix/ios fix create file base64 #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joltup#369 Resolution to the above issue, the RN code passes two instances of Content-Type, one containing capital letters and the other in lower case. The Android native code saves those options after applying .toLowerCase() on them. The data in the lower case content-type overwrote the data in the Content-Type, and since the data on both the keys wasn't updated together at the fixed part of the code, it overwrote it with invalid data and caused the request to fail.
Syncing with main branch, support for 0.60
Intent.FLAG_ACTIVITY_NEW_TASK added
Solved an issue where the rootNavigationController is not necessarily the currently displayed controller, which caused an error of: Warning: Attempt to present <SecondViewController: 0x7fb54b523240> on <ViewController: 0x7fb54b61e7f0> whose view is not in the window hierarchy!
Android to throw an exception when there's no suitable app that can open the file
# Conflicts: # android/src/main/java/com/RNFetchBlob/RNFetchBlob.java
nomadx
approved these changes
Feb 9, 2021
rpenfold
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.