Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix radio group with horizontal orientation #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luisrudge
Copy link

@luisrudge luisrudge commented Oct 22, 2024

Currently, when you use the JollyRadioGroupProps component, you can't set the orientation prop to horizontal because it's hardcoding the flex flex-col classes.

This PR removes the hardcoded classes so the style is defined by the internal RadioGroup component.

Before (vertical):
image

Before (horizontal):
image

After (vertical):
image

After (horizontal):
image

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jolly-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:33am

@luisrudge luisrudge changed the title fix radio group with vertical orientation fix radio group with horizontal orientation Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant